pin pypiwin32 version until upstream bug fixed #464

2018-01-30T19:55:35Z

meejah commented

2018-01-30 19:55:35 +00:00

(Migrated from github.com)

No description provided.

codecov-io commented

2018-01-30 20:20:33 +00:00

(Migrated from github.com)

Codecov Report

Merging #464 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   90.09%   90.09%   -0.01%     
==========================================
  Files         144      144              
  Lines       27296    27296              
  Branches     3925     3925              
==========================================
- Hits        24593    24592       -1     
  Misses       1961     1961              
- Partials      742      743       +1

Impacted Files	Coverage Δ
src/allmydata/mutable/publish.py	`95.65% <0%> (-1.02%)`	⬇️
src/allmydata/stats.py	`85.34% <0%> (-0.87%)`	⬇️
src/allmydata/immutable/upload.py	`95.25% <0%> (-0.28%)`	⬇️
src/allmydata/immutable/downloader/share.py	`95.29% <0%> (+2.46%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c04760...5f8105f. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=h1) Report > Merging [#464](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/7c047603b5bf87c7cad5451d606866dd185fa59b?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464/graphs/tree.svg?token=Ztmu9sr4vi&width=650&height=150&src=pr)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #464 +/- ## ========================================== - Coverage 90.09% 90.09% -0.01% ========================================== Files 144 144 Lines 27296 27296 Branches 3925 3925 ========================================== - Hits 24593 24592 -1 Misses 1961 1961 - Partials 742 743 +1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/mutable/publish.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3B1Ymxpc2gucHk=) | `95.65% <0%> (-1.02%)` | :arrow_down: | | [src/allmydata/stats.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zdGF0cy5weQ==) | `85.34% <0%> (-0.87%)` | :arrow_down: | | [src/allmydata/immutable/upload.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvdXBsb2FkLnB5) | `95.25% <0%> (-0.28%)` | :arrow_down: | | [src/allmydata/immutable/downloader/share.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZG93bmxvYWRlci9zaGFyZS5weQ==) | `95.29% <0%> (+2.46%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=footer). Last update [7c04760...5f8105f](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/464?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

meejah commented

2018-01-30 20:25:40 +00:00

(Migrated from github.com)

Further evidence of some kind of Heisen-coverage -- this just changes one dependency line

Sign in to join this conversation.

No reviewers