tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

magic-folder: change stopService to call MultiService.stopService #407

Closed
david415 wants to merge 1 commits from 2868.magic-folder-stop.0 into master
pull from: 2868.magic-folder-stop.0
merge into: tahoe-lafs:master
Conversation 4 Commits 1 Files Changed 1 +1 -1
david415 commented 2017-03-03 19:01:23 +00:00 (Migrated from github.com)
Copy Link
No description provided.
codecov-io commented 2017-03-03 20:51:52 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   87.96%   87.98%   +0.01%     
==========================================
  Files         145      145              
  Lines       27439    27439              
  Branches     3805     3805              
==========================================
+ Hits        24138    24143       +5     
+ Misses       2600     2595       -5     
  Partials      701      701
Impacted Files Coverage Δ
src/allmydata/frontends/magic_folder.py 83.85% <100%> (ø) ✅
src/allmydata/immutable/upload.py 96.24% <0%> (-0.1%) ❌
src/allmydata/immutable/checker.py 87.94% <0%> (+0.25%) ✅
src/allmydata/mutable/servermap.py 94.2% <0%> (+0.32%) ✅
src/allmydata/util/dictutil.py 97.89% <0%> (+0.7%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb782b0...6426da0. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/407?src=pr&el=h1) Report > Merging [#407](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/407?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/bb782b0331a60de438136a593bba18338d8d866b?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## master #407 +/- ## ========================================== + Coverage 87.96% 87.98% +0.01% ========================================== Files 145 145 Lines 27439 27439 Branches 3805 3805 ========================================== + Hits 24138 24143 +5 + Misses 2600 2595 -5 Partials 701 701 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/407?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/frontends/magic_folder.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9mcm9udGVuZHMvbWFnaWNfZm9sZGVyLnB5) | `83.85% <100%> (ø)` | :white_check_mark: | | [src/allmydata/immutable/upload.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvdXBsb2FkLnB5) | `96.24% <0%> (-0.1%)` | :x: | | [src/allmydata/immutable/checker.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvY2hlY2tlci5weQ==) | `87.94% <0%> (+0.25%)` | :white_check_mark: | | [src/allmydata/mutable/servermap.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3NlcnZlcm1hcC5weQ==) | `94.2% <0%> (+0.32%)` | :white_check_mark: | | [src/allmydata/util/dictutil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2RpY3R1dGlsLnB5) | `97.89% <0%> (+0.7%)` | :white_check_mark: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/407?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/407?src=pr&el=footer). Last update [bb782b0...6426da0](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/bb782b0331a60de438136a593bba18338d8d866b...6426da0c04d0b82f790f6af15fbf401ce7fbe284?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
meejah commented 2017-03-13 18:16:25 +00:00 (Migrated from github.com)
Copy Link

👍 looks good to me!

:+1: looks good to me!
david415 commented 2017-04-10 16:55:58 +00:00 (Migrated from github.com)
Copy Link

i'm a simple one line patch, merge me?

i'm a simple one line patch, merge me?
warner commented 2017-04-10 18:39:44 +00:00 (Migrated from github.com)
Copy Link

Landing (rebased) in 0599adf8. One thing to consider, that gatherResults means the child Services and MagicFolder.finish will run in parallel. If there's any reason why you need finish to finish before the children are told to stop (or vice versa), you should turn that into a sequential flow (probably with inlineCallbacks).

Landing (rebased) in 0599adf8. One thing to consider, that `gatherResults` means the child Services and `MagicFolder.finish` will run in parallel. If there's any reason why you need `finish` to finish before the children are told to stop (or vice versa), you should turn that into a sequential flow (probably with `inlineCallbacks`).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#407
No description provided.
Delete Branch "2868.magic-folder-stop.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?