tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Show the connection-status of all hints until we're connected to one #384

Closed
meejah wants to merge 4 commits from 2819.nicer-disconnected-status.0 into master
pull from: 2819.nicer-disconnected-status.0
merge into: tahoe-lafs:master
Conversation 3 Commits 4 Files Changed 7 +98 -147
meejah commented 2016-12-09 20:21:49 +00:00 (Migrated from github.com)
Copy Link

This shows the connection-status of each individual hint for any connections that have not yet succeeded.

connections-screenshot

This shows the connection-status of each individual hint for any connections that have not yet succeeded. ![connections-screenshot](https://cloud.githubusercontent.com/assets/145599/21063353/64acce62-be12-11e6-8377-fae97c4c7aa9.png)
warner commented 2016-12-10 01:05:45 +00:00 (Migrated from github.com)
Copy Link

I've made some patches on top of this to do more cleanups. In this one, the tooltip is only shown on the connected case, displaying only the non-winning hints (but in roughly the same layout as the <ul> would be). The non-connected case shows all hints as a <ul>, and has no tooltip.

tahoe1

When there's only one hint, and we're connected to it (like on server s1 in my screenshot), the tooltop shows a "no other hints" message:

tahoe2

I also removed the really Nevow-specific IContainer stuff in favor of a merely-somewhat-Nevow-specific T.ul[] STAN markup (which should be easier to port to twisted.web.template some day).

I've made some patches on top of this to do more cleanups. In this one, the tooltip is only shown on the connected case, displaying only the non-winning hints (but in roughly the same layout as the `<ul>` would be). The non-connected case shows all hints as a `<ul>`, and has no tooltip. ![tahoe1](https://cloud.githubusercontent.com/assets/27146/21069694/33264372-be31-11e6-8aa9-c3f98e7121f6.png) When there's only one hint, and we're connected to it (like on server `s1` in my screenshot), the tooltop shows a "no other hints" message: ![tahoe2](https://cloud.githubusercontent.com/assets/27146/21069724/513cd29a-be31-11e6-9d2d-b2125cbf0eef.png) I also removed the really Nevow-specific `IContainer` stuff in favor of a merely-somewhat-Nevow-specific `T.ul[]` STAN markup (which should be easier to port to twisted.web.template some day).
codecov-io commented 2016-12-10 01:57:14 +00:00 (Migrated from github.com)
Copy Link

Current coverage is 89.80% (diff: 94.73%)

Merging #384 into master will decrease coverage by 0.03%

@@             master       #384   diff @@
==========================================
  Files           136        136          
  Lines         26849      26835    -14   
  Methods           0          0          
  Messages          0          0          
  Branches       3744       3746     +2   
==========================================
- Hits          24122      24100    -22   
- Misses         2025       2028     +3   
- Partials        702        707     +5

Powered by Codecov. Last update 8b35fe9...3633257

## [Current coverage](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/384?src=pr) is 89.80% (diff: 94.73%) > Merging [#384](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/384?src=pr) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/branch/master?src=pr) will decrease coverage by **0.03%** ```diff @@ master #384 diff @@ ========================================== Files 136 136 Lines 26849 26835 -14 Methods 0 0 Messages 0 0 Branches 3744 3746 +2 ========================================== - Hits 24122 24100 -22 - Misses 2025 2028 +3 - Partials 702 707 +5 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [8b35fe9...3633257](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/compare/8b35fe9efe377e2649707df9563ef1d27eeb01f6...363325785ff3551f182ed2529921ab5861ad2cc3?src=pr)
warner commented 2016-12-10 02:43:37 +00:00 (Migrated from github.com)
Copy Link

alright, I think that's good, I'm going to rebase and land it, in 7d9b76f49b.

alright, I think that's good, I'm going to rebase and land it, in 7d9b76f49bd19f3f275fd175a98aba431e5e43e4.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#384
No description provided.
Delete Branch "2819.nicer-disconnected-status.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?