tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Make StorageFarmBroker use specified or default handler #317

Merged
david415 merged 1 commits from 2788.use_specified_or_default_handlers.0 into master 2016-08-26 21:01:23 +00:00
Conversation 4 Commits 1 Files Changed 3 +12 -6
david415 commented 2016-08-25 17:25:26 +00:00 (Migrated from github.com)
Copy Link
No description provided.
warner commented 2016-08-25 23:41:20 +00:00 (Migrated from github.com)
Copy Link

Um, travis reports a test failure in the new code (https://travis-ci.org/tahoe-lafs/tahoe-lafs/jobs/155118744), in test_storage_client.TestStorageFarmBroker.test_static_announcement, where got_static_announcement() is being called with the wrong number of arguments.

Could you please run the tests locally on the new code before submitting the pull request?

Um, travis reports a test failure in the new code (https://travis-ci.org/tahoe-lafs/tahoe-lafs/jobs/155118744), in `test_storage_client.TestStorageFarmBroker.test_static_announcement`, where `got_static_announcement()` is being called with the wrong number of arguments. Could you please run the tests locally on the new code before submitting the pull request?
coveralls commented 2016-08-26 10:59:18 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage increased (+0.005%) to 92.146% when pulling c6b4983d87645f55a5a0e4e0a047afc48a41c8f7 on david415:2788.use_specified_or_default_handlers.0 into de61cd260c on tahoe-lafs:master.

[![Coverage Status](https://coveralls.io/builds/7621855/badge)](https://coveralls.io/builds/7621855) Coverage increased (+0.005%) to 92.146% when pulling **c6b4983d87645f55a5a0e4e0a047afc48a41c8f7 on david415:2788.use_specified_or_default_handlers.0** into **de61cd260c70fceb082679906c28e9d474e8791f on tahoe-lafs:master**.
coveralls commented 2016-08-26 11:42:54 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage increased (+0.005%) to 92.146% when pulling 140c9a92cd on david415:2788.use_specified_or_default_handlers.0 into de61cd260c on tahoe-lafs:master.

[![Coverage Status](https://coveralls.io/builds/7622532/badge)](https://coveralls.io/builds/7622532) Coverage increased (+0.005%) to 92.146% when pulling **140c9a92cdac4945d6816c8cc242edfc6e4177a0 on david415:2788.use_specified_or_default_handlers.0** into **de61cd260c70fceb082679906c28e9d474e8791f on tahoe-lafs:master**.
warner commented 2016-08-26 21:01:10 +00:00 (Migrated from github.com)
Copy Link

I added a patch to fix the use of a non-existent dict.haskey (it's spelled has_key). Landing now.

I'm going to make some deep changes to this code today (corresponding to the most recent comment on ticket 2788), so you might want to avoid hacking on these files for the next few days.

I added a patch to fix the use of a non-existent `dict.haskey` (it's spelled `has_key`). Landing now. I'm going to make some deep changes to this code today (corresponding to the [most recent comment on ticket 2788](https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2788#comment:22)), so you might want to avoid hacking on these files for the next few days.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#317
No description provided.
Delete Branch "2788.use_specified_or_default_handlers.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?