tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Fix ftp 'ls' to work with current Twisted-15.0.0 #148

Closed
warner wants to merge 3 commits from ftp-2394 into master
pull from: ftp-2394
merge into: tahoe-lafs:master
Conversation 1 Commits 3 Files Changed 3 +24 -5
warner commented 2015-03-26 01:33:42 +00:00 (Migrated from github.com)
Copy Link

refs ticket:2394

It's kind of a hack, but Twisted changed the API and I couldn't find a
cleaner way to detect which form of "permissions" value the Twisted FTP
server wants.

I've manually tested it against 14.0.2 and 15.0.0. I can't get a working Twisted-11.0.0 environment to test that corner case directly, but I force-enabled the workaround for it and that works too, so I'm pretty sure it'll work there.

refs ticket:2394 It's kind of a hack, but Twisted changed the API and I couldn't find a cleaner way to detect which form of "permissions" value the Twisted FTP server wants. I've manually tested it against 14.0.2 and 15.0.0. I can't get a working Twisted-11.0.0 environment to test that corner case directly, but I force-enabled the workaround for it and that works too, so I'm pretty sure it'll work there.
warner commented 2015-03-31 18:09:45 +00:00 (Migrated from github.com)
Copy Link

Oops, I rebashed and pushed with the fixed typo but without squashing. d7b763c795. Eh, close enough.

Oops, I rebashed and pushed with the fixed typo but without squashing. d7b763c7950f6c8bb3143d8409f89a3a63ec6dbe. Eh, close enough.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#148
No description provided.
Delete Branch "ftp-2394"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?