tahoe-lafs/tahoe-lafs
tahoe-lafs/tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

put a version string in the name of the OS-X .pkg file #146

Merged
warner merged 2 commits from versioned-osx-pkg into master 2015-03-24 16:11:30 +00:00
Conversation 2 Commits 2 Files Changed 3 +39 -26
warner commented 2015-03-21 21:21:00 +00:00 (Migrated from github.com)
Copy Link

Addresses https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2393

Addresses https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2393
coveralls commented 2015-03-21 21:46:53 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 92.39% when pulling c12d49b54e on warner:versioned-osx-pkg into 7846f5f9c8 on tahoe-lafs:master.

[![Coverage Status](https://coveralls.io/builds/2165845/badge)](https://coveralls.io/builds/2165845) Coverage remained the same at 92.39% when pulling **c12d49b54e1d624462f1bc78dde2e733ef2cd6b5 on warner:versioned-osx-pkg** into **7846f5f9c87905768762ae494855fcbe7bdd4bb7 on tahoe-lafs:master**.
warner commented 2015-03-24 17:00:09 +00:00 (Migrated from github.com)
Copy Link

In the long run, the version will be computed with python setup.py version, instead of slicing it out of _version.py, but that can live equally well in the Makefile or in build-osx-pkg.py . So moving it down into the script sounds fine to me.

In the long run, the version will be computed with `python setup.py version`, instead of slicing it out of `_version.py`, but that can live equally well in the Makefile or in build-osx-pkg.py . So moving it down into the script sounds fine to me.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#146
No description provided.
Delete Branch "versioned-osx-pkg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?