Remove pylint and flake8, replacing with ruff #1290
No reviewers
Labels
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: tahoe-lafs/tahoe-lafs#1290
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "4014-remove-pylint"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/4014
As a follow-up we should probably start enabling a lot more checks. I estimate running every single check on CI would take maybe 4 seconds (on my computer it's 300ms due to multiple cores and faster CPU). This would create a bunch of noise so we don't want everything, but there are many more checks that would be useful to have.
Impacts on
codechecks
runtime in CI:skip_install = true
intox.ini
shaved off another 20 seconds.Thanks. One comment inline. Please address and merge.
The version in setup.py is pinned precisely but this one is unpinned.
It's not even entirely obvious to me why we have this (or why we had pyflakes) as a dependency in setup.py. So devs could get the tools with
pip install ...[test]
I guess? It would be nice to declare this only once and (I guess?) for the declaration to include a version pin.I have a follow-up PR that I'll open once this one is merged which adds pinning.
Actually, no, I didn't. So I'll make them match.
The reason for duplication is faster CI; it allows not installing everything on each CI run, just ruff. Not quite sure how to fix that... maybe a
.ruff.version
file?I guess setup.py could extract the ruff version from tox.ini with a regex but oh god.