tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Address various http storage holistic review comments #1216

Merged
itamarst merged 5 commits from 3904-http-storage-holistic into master 2022-10-03 13:13:30 +00:00
Conversation 1 Commits 5 Files Changed 6 +77 -69
itamarst commented 2022-09-15 14:39:23 +00:00 (Migrated from github.com)
Copy Link

Fixes (partially? completely?) https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3904

  1. Switched NURL docs to SHA-256, to match RFC.
  2. Omitted NURL from version response. By the time you're getting that, you already have the NURL, I would expect. If we find additional use cases, we can adjust.
  3. Switched prefix to /storage/v1.

I have also started thinking about implications of the new-to-me NURL spec.

Fixes (partially? completely?) https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3904 1. Switched NURL docs to SHA-256, to match RFC. 2. Omitted NURL from version response. By the time you're getting that, you already have the NURL, I would expect. If we find additional use cases, we can adjust. 3. Switched prefix to `/storage/v1`. I have also started thinking about implications of the new-to-me NURL spec.
coveralls commented 2022-09-15 15:37:59 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 94.701% when pulling f5b374a7a2 on 3904-http-storage-holistic into 7c25e1533f on master.

[![Coverage Status](https://coveralls.io/builds/52507104/badge)](https://coveralls.io/builds/52507104) Coverage remained the same at 94.701% when pulling **f5b374a7a2ad95232e8cddca3d9d334f4f4b6986 on 3904-http-storage-holistic** into **7c25e1533f395fb26d8403ea39409e746cd3684e on master**.
exarkun (Migrated from github.com) approved these changes 2022-10-03 13:08:57 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. Looks good to me.

Thanks. Looks good to me.
Sign in to join this conversation.
Reviewers
No reviewers
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1216
No description provided.
Delete Branch "3904-http-storage-holistic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?