tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

2249 windows dep workaround 5 #118

Merged
daira merged 11 commits from 2249-windows-dep-workaround-5 into master 2014-10-08 11:45:54 +00:00
Conversation 1 Commits 11 Files Changed 46 +179 -62
daira commented 2014-10-07 18:20:10 +00:00 (Migrated from github.com)
Copy Link

Make dependencies different for Windows and non-Windows. fixes #2249
Only allow pyOpenSSL >= 0.14 if it is already installed. fixes #2193

Make dependencies different for Windows and non-Windows. fixes #2249 Only allow pyOpenSSL >= 0.14 if it is already installed. fixes #2193
daira commented 2014-10-07 19:14:11 +00:00 (Migrated from github.com)
Copy Link

Note that this branch differs from 2249-windows-dep-workaround-2 in the following ways:

  • all review comments should have been addressed
  • the extra logging in zetuptoolz is no longer vulnerable to format string confusion (thanks for pointing that out @nejucomo !)
  • it has this extra patch which accepts pyOpenSSL >= 0.14 as a dependency only when it is already installed and importable: [18ffc29f49]

This does not check that the importable pyOpenSSL is not vulnerable to Heartbleed or is in any particular set of versions; I want to address that separately if we decide to do so for 1.11.

Note that this branch differs from 2249-windows-dep-workaround-2 in the following ways: - all review comments should have been addressed - the extra logging in zetuptoolz is no longer vulnerable to format string confusion (thanks for pointing that out @nejucomo !) - it has this extra patch which accepts pyOpenSSL >= 0.14 as a dependency only when it is already installed and importable: [18ffc29f4949b6098b8b89e6e89c89923121cda2] This does _not_ check that the importable pyOpenSSL is not vulnerable to Heartbleed or is in any particular set of versions; I want to address that separately if we decide to do so for 1.11.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#118
No description provided.
Delete Branch "2249-windows-dep-workaround-5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?