tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Switch Nix packaging to use mach-nix #1175

Merged
exarkun merged 34 commits from 3867.mach-nix into master 2022-01-28 17:00:08 +00:00
Conversation 3 Commits 34 Files Changed 17 +530 -445
exarkun commented 2022-01-27 18:25:59 +00:00 (Migrated from github.com)
Copy Link

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3867

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3867
coveralls commented 2022-01-27 20:54:47 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage decreased (-0.02%) to 95.689% when pulling 9ba17ba8d1 on 3867.mach-nix into 6480e0c8d3 on master.

[![Coverage Status](https://coveralls.io/builds/46040884/badge)](https://coveralls.io/builds/46040884) Coverage decreased (-0.02%) to 95.689% when pulling **9ba17ba8d1731ba004587144d0e5b0b63f870fcd on 3867.mach-nix** into **6480e0c8d3ae39632aa68fb740ae1b895ce818c4 on master**.
itamarst (Migrated from github.com) approved these changes 2022-01-28 15:14:22 +00:00
itamarst (Migrated from github.com) left a comment
Copy Link

Thanks for doing this, I would not have managed it. Other than two minor comments, you'll also need to make nix 19.09 not required in GitHub settings.

Thanks for doing this, I would not have managed it. Other than two minor comments, you'll also need to make nix 19.09 not required in GitHub settings.
.circleci/config.yml
itamarst (Migrated from github.com) commented 2022-01-28 15:01:46 +00:00
Copy Link

Maybe add explanatory comment about what this does? Or the overall process? This is quite opaque, and the linked page only covers the push part.

Maybe add explanatory comment about what this does? Or the overall process? This is quite opaque, and the linked page only covers the push part.
nix/sources.json
@ -0,0 +1,62 @@
{
itamarst (Migrated from github.com) commented 2022-01-28 15:05:26 +00:00
Copy Link

I assume this will occasionally need to be updated. Can you document how to do so?

I assume this will occasionally need to be updated. Can you document how to do so?
exarkun commented 2022-01-28 15:21:37 +00:00 (Migrated from github.com)
Copy Link

Thanks for doing this, I would not have managed it.

Thanks for the review. This definitely ended up about 5x more complicated than I expected. :( But hopefully the upside makes it worthwhile (we should not really have to write any more per-package Nix expressions).

> Thanks for doing this, I would not have managed it. Thanks for the review. This definitely ended up about 5x more complicated than I expected. :( But hopefully the upside makes it worthwhile (we should not really have to write any more per-package Nix expressions).
exarkun commented 2022-01-28 16:59:45 +00:00 (Migrated from github.com)
Copy Link

I clicked GitHub buttons to remove "ci/circleci: nixos-19-09" from the required status list for the "master" branch protection configuration for the project.

I clicked GitHub buttons to remove "ci/circleci: nixos-19-09" from the required status list for the "master" branch protection configuration for the project.
Sign in to join this conversation.
Reviewers
No reviewers
itamarst
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1175
No description provided.
Delete Branch "3867.mach-nix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?