tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Immutable uploads time out if no writes are done for 30 minutes #1162

Merged
itamarst merged 12 commits from 3807.immutable-upload-timeout into master 2021-11-23 16:01:26 +00:00
Conversation 1 Commits 12 Files Changed 6 +143 -48
itamarst commented 2021-11-18 20:44:10 +00:00 (Migrated from github.com)
Copy Link

Mostly useful for HTTP uploads.

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3807

Mostly useful for HTTP uploads. Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3807
coveralls commented 2021-11-18 21:17:29 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage decreased (-0.001%) to 95.663% when pulling c341a86abd on 3807.immutable-upload-timeout into d3c6f58a8d on master.

[![Coverage Status](https://coveralls.io/builds/44484429/badge)](https://coveralls.io/builds/44484429) Coverage decreased (-0.001%) to 95.663% when pulling **c341a86abdd4aa2b4244d0adeff53d5893be9a03 on 3807.immutable-upload-timeout** into **d3c6f58a8ded7db3324ef97c47f5c1921c3d58b7 on master**.
meejah (Migrated from github.com) approved these changes 2021-11-22 16:44:42 +00:00
meejah (Migrated from github.com) left a comment
Copy Link

LGTM, some inline comments

LGTM, some inline comments
src/allmydata/storage/server.py
@ -15,3 +15,3 @@
from typing import Dict
import os, re, time
import os, re
meejah (Migrated from github.com) commented 2021-11-22 16:41:21 +00:00
Copy Link

\O/

\O/
src/allmydata/storage/server.py
meejah (Migrated from github.com) commented 2021-11-22 16:42:05 +00:00
Copy Link

probably don't need the list()?

probably don't need the `list()`?
src/allmydata/test/test_storage.py
meejah (Migrated from github.com) commented 2021-11-22 16:43:59 +00:00
Copy Link

comment doesn't match code

comment doesn't match code
itamarst (Migrated from github.com) reviewed 2021-11-23 14:59:38 +00:00
src/allmydata/storage/server.py
itamarst (Migrated from github.com) commented 2021-11-23 14:59:38 +00:00
Copy Link

You do, when it gets disconnected it removes itself from _bucket_writers and then you're iterating over it as it gets mutated.

You do, when it gets disconnected it removes itself from `_bucket_writers` and then you're iterating over it as it gets mutated.
itamarst (Migrated from github.com) reviewed 2021-11-23 15:01:15 +00:00
src/allmydata/test/test_storage.py
itamarst (Migrated from github.com) commented 2021-11-23 15:01:15 +00:00
Copy Link

Fixed.

Fixed.
Sign in to join this conversation.
Reviewers
No reviewers
meejah
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1162
No description provided.
Delete Branch "3807.immutable-upload-timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?