tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Reduce implementation-dependency of IStorageServer #1117

Merged
itamarst merged 10 commits from 3779-istorageserver-with-fewer-assumptions into master 2021-09-13 13:28:47 +00:00
Conversation 3 Commits 10 Files Changed 8 +41 -13
itamarst commented 2021-09-02 19:26:04 +00:00 (Migrated from github.com)
Copy Link

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3779

Left in the so-called "pipeline" code, since it's not clear if it's needed or not.

Update: Also fixed a pre-existing bug in remote_advise_corrupt_share that was exposed by the changes.

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3779 Left in the so-called "pipeline" code, since it's not clear if it's needed or not. **Update:** Also fixed a pre-existing bug in remote_advise_corrupt_share that was exposed by the changes.
itamarst commented 2021-09-03 15:28:08 +00:00 (Migrated from github.com)
Copy Link

Hm. Getting the impression that I broke something with the seemingly minor tweaks I did...

Hm. Getting the impression that I broke something with the seemingly minor tweaks I did...
itamarst commented 2021-09-03 15:31:03 +00:00 (Migrated from github.com)
Copy Link

Actually—those errors were probably there before, and just were being dropped on the floor, and now they're being logged.

Actually—those errors were probably there before, and just were being dropped on the floor, and now they're being logged.
itamarst (Migrated from github.com) reviewed 2021-09-03 17:14:54 +00:00
src/allmydata/storage/server.py
@ -713,1 +712,4 @@
self.corruption_advisory_dir,
("%s--%s-%d" % (now, str(si_s, "utf-8"), shnum)).replace(":","")
)
with open(fn, "w") as f:
itamarst (Migrated from github.com) commented 2021-09-03 17:14:54 +00:00
Copy Link

This is a (easy to miss) bugfix. Previously the replace was on the whole path, thus removing all colons from paths.

This is a (easy to miss) bugfix. Previously the replace was on the _whole_ path, thus removing all colons from paths.
coveralls commented 2021-09-03 17:30:45 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage increased (+0.0007%) to 95.491% when pulling fb61e29b59 on 3779-istorageserver-with-fewer-assumptions into 056ee58e91 on master.

[![Coverage Status](https://coveralls.io/builds/42791570/badge)](https://coveralls.io/builds/42791570) Coverage increased (+0.0007%) to 95.491% when pulling **fb61e29b5933fb9f84df4fc319e48a56f8e22659 on 3779-istorageserver-with-fewer-assumptions** into **056ee58e9102abb77b75900fe363872fe328f064 on master**.
exarkun (Migrated from github.com) approved these changes 2021-09-10 13:38:37 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. Minor comments inline. Please address and merge.

Thanks. Minor comments inline. Please address and merge.
newsfragments/3779.bugfix
exarkun (Migrated from github.com) commented 2021-09-10 13:26:49 +00:00
Copy Link

Can you make it clear here that this is about behavior for a storage server running on Windows (ie, it doesn't matter where the client is running)?

Can you make it clear here that this is about behavior for a storage server running on Windows (ie, it doesn't matter where the client is running)?
src/allmydata/immutable/downloader/share.py
exarkun (Migrated from github.com) commented 2021-09-10 13:25:50 +00:00
Copy Link

Passing a descriptive (or at least distinctive) reason to log.err will make it easier to make sense of any failures logged by this code path. Can you add that here and to the other new log.err errbacks?

Passing a descriptive (or at least distinctive) *reason* to `log.err` will make it easier to make sense of any failures logged by this code path. Can you add that here and to the other new `log.err` errbacks?
Sign in to join this conversation.
Reviewers
No reviewers
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1117
No description provided.
Delete Branch "3779-istorageserver-with-fewer-assumptions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?