tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Python 3 support complete, so removed warning #1114

Merged
Fenn-CS merged 6 commits from 3781.remove-incomplete-cli-warning-python3 into master 2021-09-10 16:15:34 +00:00
Conversation 11 Commits 6 Files Changed 4 +9 -10
Fenn-CS commented 2021-08-29 15:12:18 +00:00 (Migrated from github.com)
Copy Link

Python3 porting is complete so users should not be warned when running on a python3 venv

REQUIRED FOR : Tahoe-LAFS 1.16.0 Release

Closes : https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3781

`Python3` porting is complete so users should not be warned when running on a `python3 venv` REQUIRED FOR : [`Tahoe-LAFS 1.16.0` Release](https://github.com/tahoe-lafs/tahoe-lafs/pull/1113) Closes : https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3781
🎉 1
coveralls commented 2021-08-29 15:45:38 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 95.489% when pulling 02ad7b9709 on Fenn-CS:3781.remove-incomplete-cli-warning-python3 into bbc860fdb1 on tahoe-lafs:master.

[![Coverage Status](https://coveralls.io/builds/42789887/badge)](https://coveralls.io/builds/42789887) Coverage remained the same at 95.489% when pulling **02ad7b9709328319ef568b065de878d8bb9f6cc7 on Fenn-CS:3781.remove-incomplete-cli-warning-python3** into **bbc860fdb11823ebcb8d1fa365599a2aa79b5ab7 on tahoe-lafs:master**.
itamarst commented 2021-08-30 13:57:27 +00:00 (Migrated from github.com)
Copy Link

Hm. On the one hand, it's done. On the other hand, probably worth emphasizing it's beta status and the project really wants users' feedback?

Hm. On the one hand, it's done. On the other hand, probably worth emphasizing it's beta status and the project really wants users' feedback?
exarkun commented 2021-08-30 17:24:05 +00:00 (Migrated from github.com)
Copy Link

Hm. On the one hand, it's done. On the other hand, probably worth emphasizing it's beta status and the project really wants users' feedback?

At this point in the effort, though, maybe the README or the release announcement would be a better place to emphasize this?

> Hm. On the one hand, it's done. On the other hand, probably worth emphasizing it's beta status and the project really wants users' feedback? At this point in the effort, though, maybe the README or the release announcement would be a better place to emphasize this?
exarkun commented 2021-08-30 17:28:09 +00:00 (Migrated from github.com)
Copy Link

There are two failed jobs on CircleCI. Since CircleCI built for the fork instead of the main repo, I can't make it retry them. One of them looks intermittent and unrelated for sure. The other I'm not sure about. It would be nice to see these rerun.

There are two failed jobs on CircleCI. Since CircleCI built for the fork instead of the main repo, I can't make it retry them. One of them looks intermittent and unrelated for sure. The other I'm not sure about. It would be nice to see these rerun.
Fenn-CS commented 2021-08-30 20:20:58 +00:00 (Migrated from github.com)
Copy Link

I would look into those failures.

On Mon, 30 Aug 2021, 6:28 pm Jean-Paul Calderone @.***>
wrote:

There are two failed jobs on CircleCI. Since CircleCI built for the fork
instead of the main repo, I can't make it retry them. One of them looks
intermittent and unrelated for sure. The other I'm not sure about. It would
be nice to see these rerun.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tahoe-lafs/tahoe-lafs/pull/1114#issuecomment-908535360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADNHRT3NE5B6EKOAT3KNP6LT7O5TJANCNFSM5DAKT7VA
.

I would look into those failures. On Mon, 30 Aug 2021, 6:28 pm Jean-Paul Calderone ***@***.***> wrote: > There are two failed jobs on CircleCI. Since CircleCI built for the fork > instead of the main repo, I can't make it retry them. One of them looks > intermittent and unrelated for sure. The other I'm not sure about. It would > be nice to see these rerun. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/tahoe-lafs/tahoe-lafs/pull/1114#issuecomment-908535360>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADNHRT3NE5B6EKOAT3KNP6LT7O5TJANCNFSM5DAKT7VA> > . >
itamarst commented 2021-08-30 20:55:39 +00:00 (Migrated from github.com)
Copy Link

At this point in the effort, though, maybe the README or the release announcement would be a better place to emphasize this?

Sure I don't have a strong opinion, as long as it's mentioned somewhere.

> At this point in the effort, though, maybe the README or the release announcement would be a better place to emphasize this? Sure I don't have a strong opinion, as long as it's mentioned somewhere.
Fenn-CS commented 2021-08-31 11:19:23 +00:00 (Migrated from github.com)
Copy Link

There are two failed jobs on CircleCI. Since CircleCI built for the fork instead of the main repo, I can't make it retry them. One of them looks intermittent and unrelated for sure. The other I'm not sure about. It would be nice to see these rerun.

I did an earlier rerun. Which failed again but I ran locally and found no issues, nonetheless I have fixed conflicts with updates to master and is observing one more time.

> There are two failed jobs on CircleCI. Since CircleCI built for the fork instead of the main repo, I can't make it retry them. One of them looks intermittent and unrelated for sure. The other I'm not sure about. It would be nice to see these rerun. I did an earlier rerun. Which failed again but I ran locally and found no issues, nonetheless I have fixed conflicts with updates to master and is observing one more time.
Fenn-CS commented 2021-08-31 12:04:41 +00:00 (Migrated from github.com)
Copy Link

Everything looks fine now. Where exactly, would anyone suggest we transfer the notice to? The infant-support of Python 3 was mentioned in the release draft. Perhaps we might add some emphasis there or someone else?

Everything looks fine now. Where exactly, would anyone suggest we transfer the notice to? The infant-support of Python 3 was [mentioned](https://github.com/tahoe-lafs/tahoe-lafs/pull/1113/commits/6e3a90af9b1a946745bafd3fcc03913d7cf72bfd) in the release draft. Perhaps we might add some emphasis there or someone else?
itamarst commented 2021-09-01 14:39:14 +00:00 (Migrated from github.com)
Copy Link

Maybe in the documentation as well?

Maybe in the documentation as well?
👍 2
meejah commented 2021-09-01 18:15:36 +00:00 (Migrated from github.com)
Copy Link

Yeah, I think mentioning in .. README? .. or similar would be good. Something to the effect that 1.16.x is the first "Python3 and Python2" supporting release. I guess the thing we'd want people to do with that knowledge is a) [still] file bugs found and b) prepare for the lack of "python2" in the future?

Yeah, I think mentioning in .. README? .. or similar would be good. Something to the effect that 1.16.x is the first "Python3 and Python2" supporting release. I guess the thing we'd want people to do with that knowledge is a) [still] file bugs found and b) prepare for the lack of "python2" in the future?
itamarst commented 2021-09-07 13:34:44 +00:00 (Migrated from github.com)
Copy Link

That's fine with me.

That's fine with me.
👍 1
exarkun (Migrated from github.com) approved these changes 2021-09-10 13:15:08 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. One formatting suggestion change for README.rst then I think it is good to merge.

Thanks. One formatting suggestion change for README.rst then I think it is good to merge.
README.rst
exarkun (Migrated from github.com) commented 2021-09-10 13:13:40 +00:00
Copy Link
Python 3 support has been introduced starting with Tahoe-LAFS 1.16.0, alongside Python 2.
System administrators are advised to start running Tahoe on Python 3 and should expect Python 2 support to be dropped in a future version.
Please, feel free to file issues if you run into bugs while running Tahoe on Python 3.
```suggestion Python 3 support has been introduced starting with Tahoe-LAFS 1.16.0, alongside Python 2. System administrators are advised to start running Tahoe on Python 3 and should expect Python 2 support to be dropped in a future version. Please, feel free to file issues if you run into bugs while running Tahoe on Python 3. ```
Sign in to join this conversation.
Reviewers
No reviewers
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1114
No description provided.
Delete Branch "3781.remove-incomplete-cli-warning-python3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?