tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Port more of allmydata.test utility modules to Python 3 #1034

Merged
itamarst merged 18 commits from 3667.test-utilities-python-3 into master 2021-04-07 13:10:46 +00:00
Conversation 1 Commits 18 Files Changed 18 +94 -137
itamarst commented 2021-04-05 17:03:11 +00:00 (Migrated from github.com)
Copy Link

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3667

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3667
coveralls commented 2021-04-05 17:18:47 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage decreased (-0.004%) to 94.645% when pulling 4c26c4cc6e on 3667.test-utilities-python-3 into 42a419c00e on master.

[![Coverage Status](https://coveralls.io/builds/38566428/badge)](https://coveralls.io/builds/38566428) Coverage decreased (-0.004%) to 94.645% when pulling **4c26c4cc6e78ef87533be11443ce575aca481f20 on 3667.test-utilities-python-3** into **42a419c00ee90b2708d37b3b2dc177312f15a032 on master**.
sajith (Migrated from github.com) approved these changes 2021-04-06 21:40:14 +00:00
sajith (Migrated from github.com) left a comment
Copy Link

Thanks, looks good to me! Just one question about the now-empty allmydata.test.status module.

(Update: I figured that my question has an answer in PR #1037.)

Thanks, looks good to me! Just one question about the now-empty `allmydata.test.status` module. (Update: I figured that my question has an answer in PR #1037.)
src/allmydata/test/status.py
@ -1,16 +1 @@
sajith (Migrated from github.com) commented 2021-04-06 20:29:04 +00:00
Copy Link

This file could be deleted now, right?

This file could be deleted now, right?
sajith (Migrated from github.com) reviewed 2021-04-06 21:54:54 +00:00
src/allmydata/test/status.py
@ -1,16 +1 @@
sajith (Migrated from github.com) commented 2021-04-06 21:54:54 +00:00
Copy Link

This file could be deleted now, right?

Please disregard that. I just saw that this file in fact has been deleted in #1037.

> This file could be deleted now, right? Please disregard that. I just saw that this file in fact has been deleted in #1037.
Sign in to join this conversation.
Reviewers
No reviewers
sajith
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1034
No description provided.
Delete Branch "3667.test-utilities-python-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?