tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Port allmydata.test.cli.test_invite to Python 3 #1013

Merged
itamarst merged 6 commits from 3647.more-cli-python-3 into master 2021-03-25 14:19:50 +00:00
Conversation 1 Commits 6 Files Changed 7 +43 -11
itamarst commented 2021-03-23 15:04:27 +00:00 (Migrated from github.com)
Copy Link

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3647

I tried to make the fake ensure it's the same as wormhole's interface by checking https://github.com/magic-wormhole/magic-wormhole/blob/master/src/wormhole/_interfaces.py#L105

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3647 I tried to make the fake ensure it's the same as wormhole's interface by checking https://github.com/magic-wormhole/magic-wormhole/blob/master/src/wormhole/_interfaces.py#L105
coveralls commented 2021-03-23 15:21:59 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage increased (+0.03%) to 94.521% when pulling 4b0aa41256 on 3647.more-cli-python-3 into 4257f22d77 on master.

[![Coverage Status](https://coveralls.io/builds/38178346/badge)](https://coveralls.io/builds/38178346) Coverage increased (+0.03%) to 94.521% when pulling **4b0aa412567a1d47c4d0be6c46c242a558036109 on 3647.more-cli-python-3** into **4257f22d77b727550089d0e6ae21351cf2915c9f on master**.
exarkun (Migrated from github.com) approved these changes 2021-03-24 20:06:40 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. Looks good to me. I did some manual testing after finding #1016 . There doesn't seem to be much overlap between that and this so seems fine to merge this.

Thanks. Looks good to me. I did some manual testing after finding #1016 . There doesn't seem to be much overlap between that and this so seems fine to merge this.
Sign in to join this conversation.
Reviewers
No reviewers
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#1013
No description provided.
Delete Branch "3647.more-cli-python-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?