Sajith Sasidharan
a6e32135e8
Update status page child route handler and table renderers
...
Drop nevow-isms and use twisted.web's way of doing things.
2020-05-22 22:15:45 -04:00
Sajith Sasidharan
3357f4c5ce
Make Status a MultiFormatResource
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
81dc63b511
Use twisted template tags in status page template
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
03d529c22a
Remove unused import
2020-05-22 21:33:30 -04:00
Sajith Sasidharan
9520ad71eb
Rearrange imports
2020-05-22 21:24:21 -04:00
Sajith Sasidharan
f8562530be
Make Element the superclass of UploadResultsRendererMixin
2020-05-22 21:11:42 -04:00
Sajith Sasidharan
b0e3325d03
Move time formatter tests
...
UploadResultsRendererMixin no longer has render_time(); moving tests
for render_time() as tests for abbreviate_time() to a more appropriate
place.
2020-05-22 20:49:34 -04:00
Sajith Sasidharan
91f8d939f8
Avoid use of RateAndTimeMixin in UploadResultsRendererMixin
2020-05-22 20:22:59 -04:00
Sajith Sasidharan
00f70f6539
Add newsfragment
2020-05-22 20:08:34 -04:00
Sajith Sasidharan
aecd90858a
Render abbreviated rate and time values
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
7be1883910
Document UploadResultsPage parameter
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
5fdd61b146
Document UploadStatusPage
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
54ac2d224a
Remove unused imports
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
7a82fd671f
Handle "t=upload" in UploadResultsPage POST handling
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
3bfa5a5c29
Use twisted web template in UploadResultsRendererMixin
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
57b1203d17
Make UploadResultsPage a MultiFormatResource
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
6470718691
Use twisted template tags in upload results page template
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
41300097c8
Make UploadStatusPage a MultiFormatResource
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
aac8dee8a0
Use twisted template tags in upload status page template
2020-05-22 19:39:32 -04:00
aec6e5a9d4
Force a CircleCI build
2020-05-18 20:05:16 -04:00
Sajith Sasidharan
c23fedbcfe
Add related ticket to comment about refactoring
2020-05-18 16:56:32 -04:00
Sajith Sasidharan
0b3db59742
Add related ticket to comment about unimplemented method
2020-05-18 16:56:32 -04:00
993b1e225f
Use transparent tags to render values
2020-05-18 11:01:14 -04:00
Sajith Sasidharan
c5342d8ae6
Add comments about events tables
2020-05-14 16:48:43 -04:00
Sajith Sasidharan
19e40e2193
Add newsfragment
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
ab4811eaa0
Move tests for abbreviate time/rate methods to utils tests
...
RateAndTimeMixin.render_time() is really abbreviate_time(), and
RateAndTimeMixin.render_rate() is really abbreviate_rate(). This
change moves the tests to their rightful place, and exercises them
using the right names.
We're also trying to avoid use of mixins. RateAndTimeMixin will
eventually go.
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
88e8854ad4
Wrap renderer results in tags
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
68df408229
Add a note about unimplemented DownloadStatus method
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
1fa77d8983
Avoid use of DownloadResultsRendererMixin
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
1f1f3b5f61
Remove unused render_timeline_link()
...
As it turns out, nothing is using this method.
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
f3edc8a48c
Add a note about rendering download events tables
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
b02cfa5bbe
Use more descriptive variable names
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
7e02502268
Add comments to DownloadStatusPage
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
e0241655e5
Update results renderer
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
c5b2073bf0
Avoid use of RateAndTimeMixin methods in DownloadStatusElement
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
c4b63ada55
Update events tables renderer
2020-05-14 16:09:29 -04:00
Sajith Sasidharan
c14c437152
Make DownloadStatusPage a MultiFormatResource
2020-05-14 10:21:19 -04:00
Sajith Sasidharan
8a632b6668
Use twisted tags in download status page template
2020-05-14 10:14:52 -04:00
Sajith Sasidharan
a203f9c8d8
Reformat download status page template
2020-05-14 10:14:52 -04:00
Sajith Sasidharan
538503c0f8
Merge pull request #717 from sajith/3289.status-publish-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.PublishStatusPage
Fixes: ticket:3289
2020-05-14 10:09:57 -04:00
Sajith Sasidharan
78c214b7ff
Merge pull request #716 from sajith/3290.status-retrieve-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.RetrieveStatusPage
Fixes: ticket:3290
2020-05-13 19:39:23 -04:00
Sajith Sasidharan
79a44eac33
Correct docstring to ":param <type> <name>" format
2020-05-13 19:29:41 -04:00
Sajith Sasidharan
9d5d338993
Correct docstring to ":param <type> <name>" format
2020-05-13 19:04:10 -04:00
Sajith Sasidharan
d87dfaf5a0
Merge pull request #714 from sajith/3291.status-mapupdate-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.MapupdatePage
Fixes: ticket:3291
2020-05-13 18:22:16 -04:00
ebe80221d5
Add missing "param:" to init method docstring
2020-05-13 17:45:08 -04:00
2e0e210c14
Make PublishStatusPage comment a docstring
2020-05-13 17:43:55 -04:00
5aa0dd4085
Rename a variable for readability
...
Noticed in code review: `l` can be confused with `1` for many
typefaces.
2020-05-13 17:12:08 -04:00
812f03934a
Add missing "param:" to docstring
2020-05-13 17:09:53 -04:00
4af2e4b4df
Drop an unbalanced quote
2020-05-13 17:08:26 -04:00
62760c0997
Make RetrieveStatusPage comment a docstring
2020-05-13 17:07:09 -04:00
Sajith Sasidharan
Sajith Sasidharan