Commit Graph

13896 Commits

Author SHA1 Message Date
meejah a9f4210014 streap -> stream 2020-06-30 08:15:58 -06:00
Sajith Sasidharan f9e864c51c Use simpler syntax to update map 2020-06-24 08:15:18 -04:00
Sajith Sasidharan 88d3fa7415 Remove now-unnecessary UploadResultsPage.render_UPLOAD 2020-06-23 21:54:23 -04:00
Sajith Sasidharan dfbb8e7743 Make UploadResultsPage a Resource 2020-06-23 21:53:39 -04:00
Sajith Sasidharan 6ab7f26faf Make UploadStatusPage a Resource 2020-06-23 21:28:31 -04:00
Sajith Sasidharan 00e852c465 Make DownloadStatus an object
PythonTwoRegressions.test_new_style_classes would be unhappy without
this.
2020-06-23 20:54:49 -04:00
Sajith Sasidharan 36ecd8f384 Use render_GET()
Implementing `render_METHOD()` is preferred over overriding render()
2020-06-23 20:54:49 -04:00
Sajith Sasidharan b14c0a0495 Make DownloadStatusPage a Resource
No need of this being a MultiFormatResource, because it renders just
HTML.
2020-06-23 20:54:49 -04:00
Sajith Sasidharan 7d93ae9213 Skip Tor tests on Windows 2020-06-22 20:18:00 -04:00
Sajith Sasidharan 9b68b484bd Run integration tests on Windows on GitHub Actions
Integration tests are currently not run on Windows, because they
turned out to be a little unreliable: sometimes they fail, and when
that happens restarting the test would make things pass.

We will re-enable them and see what happens.
2020-06-22 16:32:26 -04:00
meejah aedc58ef51 unused imports 2020-06-19 17:22:42 -06:00
meejah f0ac5a2cef more-testtools-y asserts 2020-06-19 17:19:30 -06:00
meejah 57eb875354 testtool's asserts 2020-06-19 17:16:39 -06:00
meejah ef71fc2bfc Get rid of ?replace= handling entirely and more-correctly support /uri variants 2020-06-19 17:15:01 -06:00
Sajith Sasidharan df01c65540 Add newsfragment 2020-06-18 18:38:24 -04:00
Sajith Sasidharan 982ad8942e Comment about nevow.url usage in web.operations.OphandleTable 2020-06-18 18:30:18 -04:00
Sajith Sasidharan 2d2e8a5872 Add comments to web.operations.OphandleTable 2020-06-18 18:29:39 -04:00
Sajith Sasidharan bbee23b493 Rename a parameter for clarity
"context" is nevow terminology, whereas these are really requests.
2020-06-18 18:29:39 -04:00
Sajith Sasidharan 5ec78641db Make web.operations.OphandleTable a twisted web Resource 2020-06-18 18:29:27 -04:00
Sajith Sasidharan 6f8af688dd Rearrange imports 2020-06-18 18:01:18 -04:00
Sajith Sasidharan dfb477a2b1 Remove unused import 2020-06-17 22:09:50 -04:00
Sajith Sasidharan e121cc0a84 Use the right names
Missed this in testing because this code was not reached in testing.
2020-06-17 22:09:50 -04:00
Sajith Sasidharan 4f213e93be Remove an unused variable 2020-06-17 22:04:08 -04:00
Sajith Sasidharan 0483fc91c1 Remove unused import 2020-06-17 22:04:08 -04:00
Sajith Sasidharan c3440ce213 Use a helper to query monitor counters 2020-06-17 21:53:11 -04:00
Sajith Sasidharan 47f9147e16 Rename a class for consistency's sake 2020-06-17 21:46:40 -04:00
Sajith Sasidharan c8d218fb9f Add newsfragment 2020-06-17 21:18:14 -04:00
Sajith Sasidharan fe1b0cb7ed Rename class variables 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 22977352bb Document parameters of ResultsRenderer classes 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 79be795566 Remove unused want_json() 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 23a51117d2 Rename `r` to `check_results` 2020-06-17 21:18:14 -04:00
Sajith Sasidharan fae4f44404 Prefer `req` to `ctx` 2020-06-17 21:18:14 -04:00
Sajith Sasidharan cdb3747470 Remove nevow imports 2020-06-17 21:18:14 -04:00
Sajith Sasidharan de99912641 Replace `ctx` references with `req` references 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 1ee756c8df Use Beautiful Soup to check for favicon 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 2e60408bf6 Wrap counters in <span> tags
Unless the rendered page contains strings of the form "Objects
Checked: <span>n</span>" etc, test_POST_DIRURL_deepcheck will not
pass.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan 33ddac879c Remove unused code 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 8094b3144d Use SlotsSequenceElement to render all objects 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 4e594b09bf Use SlotsSequenceElement to render corrupt shares 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 46cb3b6bc3 Use SlotsSequenceElement to render servers with corrupt shares 2020-06-17 21:18:14 -04:00
Sajith Sasidharan c41bca24f5 Use SlotsSequenceElement to render deep check results problems 2020-06-17 21:18:14 -04:00
Sajith Sasidharan bbd6bde478 Use SlotsSequenceElement to render remaining corrupt shares
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan 19f6ec7102 Use SlotsSequenceElement to render servers with corrupt shares
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan e0c686bb92 Use SlotsSequenceElement to render post-repair problems 2020-06-17 21:18:14 -04:00
Sajith Sasidharan f168dcd19c Use SlotsSequenceElement to render pre-repair problems 2020-06-17 21:18:14 -04:00
Sajith Sasidharan c7aa789a22 Fix "class has no children attribute" error 2020-06-17 21:18:14 -04:00
Sajith Sasidharan cfb1560d15 Render "all objects" table using SlotsSequenceElement 2020-06-17 21:18:14 -04:00
Sajith Sasidharan 3783349ea7 Add span tags to "deep check and repair results" template
Tests expect <span> tags around these numbers, let us add those.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan c4be4b566c Make TestRequest an object
Wouldn't pass PythonTwoRegressions.test_new_style_classes without
this.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan 048840ac99 Stringify numbers 2020-06-17 21:18:14 -04:00