tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

run-deprecations: supress duplicates 

I thought 'warnings' or twisted.python.deprecate was supposed to do this
already, but it's clearly not working.
This commit is contained in:
Brian Warner 2016-04-06 13:33:43 -10:00
parent 9d20de3db9
commit b81c6a7208
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
misc/build_helpers/run-deprecations.py
View File

@ -61,17 +61,25 @@ def run_command(main):
reactor.spawnProcess(pp, exe, [exe] + config["args"], env=None) reactor.spawnProcess(pp, exe, [exe] + config["args"], env=None)
(signal, rc) = yield pp.d (signal, rc) = yield pp.d
# maintain ordering, but ignore duplicates (for some reason, either the
# 'warnings' module or twisted.python.deprecate isn't quashing them)
already = set()
warnings = [] warnings = []
def add(line):
if line in already:
return
already.add(line)
warnings.append(line)
pp.stdout.seek(0) pp.stdout.seek(0)
for line in pp.stdout.readlines(): for line in pp.stdout.readlines():
if "DeprecationWarning" in line: if "DeprecationWarning" in line:
warnings.append(line) # includes newline add(line) # includes newline
pp.stderr.seek(0) pp.stderr.seek(0)
for line in pp.stderr.readlines(): for line in pp.stderr.readlines():
if "DeprecationWarning" in line: if "DeprecationWarning" in line:
warnings.append(line) add(line)
if warnings: if warnings:
if config["warnings"]: if config["warnings"]: