Use bigger random one-time keys in timing_safe_compare. fixes #2165
Follows this advice from Marsh Ray and Solar Designer: https://twitter.com/zooko/status/431105294777597952 Signed-off-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
parent
d5651a0d0e
commit
6ca5f5fc39
|
@ -203,7 +203,7 @@ def ssk_storage_index_hash(readkey):
|
||||||
return tagged_hash(MUTABLE_STORAGEINDEX_TAG, readkey, KEYLEN)
|
return tagged_hash(MUTABLE_STORAGEINDEX_TAG, readkey, KEYLEN)
|
||||||
|
|
||||||
def timing_safe_compare(a, b):
|
def timing_safe_compare(a, b):
|
||||||
n = os.urandom(8)
|
n = os.urandom(32)
|
||||||
return bool(tagged_hash(n, a) == tagged_hash(n, b))
|
return bool(tagged_hash(n, a) == tagged_hash(n, b))
|
||||||
|
|
||||||
BACKUPDB_DIRHASH_TAG = "allmydata_backupdb_dirhash_v1"
|
BACKUPDB_DIRHASH_TAG = "allmydata_backupdb_dirhash_v1"
|
||||||
|
|
Loading…
Reference in New Issue