tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Merge pull request #1256 from danielzwlee/3971.mypy-config 

Configure mypy to be more strict

Fixes ticket:3971
This commit is contained in:
Itamar Turner-Trauring 2023-02-07 12:32:00 -05:00 committed by GitHub
parent 0c507dc5db eb26c97ef7
commit 45d9ed8a99
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mypy.ini
View File

@ -1,3 +1,10 @@
[mypy] [mypy]
ignore_missing_imports = True ignore_missing_imports = True
plugins=mypy_zope:plugin plugins=mypy_zope:plugin
show_column_numbers = True
pretty = True
show_error_codes = True
warn_unused_configs =True
no_implicit_optional = True
warn_redundant_casts = True
strict_equality = True

1
newsfragments/3971.minor Normal file
View File

@ -0,0 +1 @@
Changes made to mypy.ini to make mypy more 'strict' and prevent future regressions.

6
src/allmydata/web/common.py
View File

@ -707,12 +707,12 @@ def url_for_string(req, url_string):
T = TypeVar("T") T = TypeVar("T")
@overload @overload
def get_arg(req: IRequest, argname: str | bytes, default: T = None, *, multiple: Literal[False] = False) -> T | bytes: ... def get_arg(req: IRequest, argname: str | bytes, default: Optional[T] = None, *, multiple: Literal[False] = False) -> T | bytes: ...
@overload @overload
def get_arg(req: IRequest, argname: str | bytes, default: T = None, *, multiple: Literal[True]) -> T | tuple[bytes, ...]: ... def get_arg(req: IRequest, argname: str | bytes, default: Optional[T] = None, *, multiple: Literal[True]) -> T | tuple[bytes, ...]: ...
def get_arg(req: IRequest, argname: str | bytes, default: T = None, *, multiple: bool = False) -> None | T | bytes | tuple[bytes, ...]: def get_arg(req: IRequest, argname: str | bytes, default: Optional[T] = None, *, multiple: bool = False) -> None | T | bytes | tuple[bytes, ...]:
"""Extract an argument from either the query args (req.args) or the form """Extract an argument from either the query args (req.args) or the form
body fields (req.fields). If multiple=False, this returns a single value body fields (req.fields). If multiple=False, this returns a single value
(or the default, which defaults to None), and the query args take (or the default, which defaults to None), and the query args take